Add support for github 'bugrefs' #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
force-pushed
the
feature/gh_marker
branch
from
18869bf
to
a705315
Compare
Martchus
reviewed
Oct 31, 2016
| use Test::More; | ||
| use Test::Mojo; | ||
| use Test::Warnings; | ||
| use Test::Output qw/stderr_like/; |
There was a problem hiding this comment.
This is probably not required.
But it might make sense to merge this file with 16-utils-runcmd.t anyways.
There was a problem hiding this comment.
Thanks. Deleted unused uses. But I don't want to merge with 16-utils-runcmd.t which loads the database and is therefore way slower than 16-utils.t which is only using the functions which don't need the database and is near instantly finished.
okurz
force-pushed
the
feature/gh_marker
branch
from
a705315
to
ba52f40
Compare
aaannz
reviewed
Nov 1, 2016
| ); | ||
| my %bugurls = ( | ||
| 'https://bugzilla.novell.com/show_bug.cgi?id=' => 'bsc', | ||
| $bugrefs{bsc} => 'bsc', | ||
| $bugrefs{boo} => 'boo', | ||
| $bugrefs{poo} => 'poo', | ||
| 'https://github.com/' => 'gh', |
There was a problem hiding this comment.
Just wondering why you didn't use $bugrefs{gh}?
There was a problem hiding this comment.
probably it differed during my development but does not anymore now. I will correct.
Add support for generic github repo markers as 'bugrefs Using the generic profile '<marker>[#<project/repo>]#<id>' for all bugrefs, especially for github, allows to track all issues reported on github and especially test fixing pull requests to be recorded as 'bugrefs' with the same icon as for "test issues", i.e. poo#. This way there is no need to create a ticket just to track a test issue for which already a github pull request exist because otherwise the URL to the github PR would not mean anything special to github and therefore not mark a job as "labeled". Also, pasting full github URLs is supported, same as for all other bugrefs, meaning that the URL is abbreviated into short form bugrefs. The pattern follows the openSUSE/OBS recommendation.
okurz
force-pushed
the
feature/gh_marker
branch
from
ba52f40
to
402ebd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generic github repo markers as 'bugrefs
Using the generic profile
'[#<project/repo>]#'
for all bugrefs, especially for github, allows to
track all issues reported on github and especially
test fixing pull requests to be recorded as 'bugrefs'
with the same icon as for "test issues", i.e. poo#.
This way there is no need to create a ticket just
to track a test issue for which already a github
pull request exist because otherwise the URL to the
github PR would not mean anything special to github
and therefore not mark a job as "labeled".
Also, pasting full github URLs is supported, same as
for all other bugrefs, meaning that the URL is
abbreviated into short form bugrefs.
The pattern follows the openSUSE/OBS recommendation.